ACP step callback falsey tool result handling
Cluster 10845 · acp. Data as of
Nothing open on GitHub. Fix merged in #109109 on 12 Sep 2026. Check it covers your case.
The short answer
- Known?
- Yes. 3 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #109109. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #109109. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These issues and PRs concern a bug where falsey values (such as empty strings) returned as tool results are incorrectly overwritten with None in the ACP step callback. The proposed fix changes a truthiness check to a key-presence check to preserve such values.
Open issues0
Open PRs0
Fixes on record
-
#109109 fix(acp): empty-string tool results and messages=[] reach ACP clients unchanged (#10845, #10844, salvage #10868)
files:
acp_adapter/events.py,acp_adapter/server.py,tests/acp/test_events.py,tests/acp/test_server.py
1 PR closed without merging
From the close comments: merged via another change 1
-
#10868 fix(acp): preserve falsey tool results in step callback · merged via another change →
#109109,#10844
Closed issues · 1
- Closed#10845ACP step callback rewrites empty-string tool results to None
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the LabAt a glance
- Subsystem
- acp
- Merged PRs
- #109109
- Closed issues
- 1
- Attempts
- 1 PR closed without merging
- Fix link checked
- 12 Sep 2026