Cairn

Fix ensureContrast ladder termination for invalid steps

NousResearch/hermes-agent · cluster 109955

Data as of

Nothing open on GitHub. Fix merged in #122076. Check it covers your case.

The short answer

0open issues
0open PRs
6items grouped
Known?
Yes. 6 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #122076. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #122076. That is separate from the fix event.
Still open
Nothing open on GitHub.

These issues and PRs address a bug where the ensureContrast function fails to terminate or meet contrast requirements when given invalid or non-advancing step values. The fixes focus on validating and normalizing step inputs before the ladder loop runs.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #122076 fix: ensureContrast step validation, streaming reasoning_details, reply-scoped Copy/Read-aloud, axios lockfile, expected-quit forensics

    merged to main

    files: agent/chat_completion_helpers.py, agent/reasoning_summaries.py, apps/desktop/electron/crash-forensics.test.ts, apps/desktop/electron/crash-forensics.ts, apps/desktop/electron/local-backend-lifecycle.test.ts, apps/desktop/electron/local-backend-lifecycle.ts, apps/desktop/electron/ssh-bootstrap-coordinator.test.ts, apps/desktop/electron/ssh-bootstrap-coordinator.ts, apps/desktop/src/components/assistant-ui/thread/assistant-message.tsx, apps/desktop/src/components/assistant-ui/thread/response-copy-scope.test.tsx, apps/desktop/src/components/assistant-ui/thread/response-group.test.tsx, apps/desktop/src/i18n/ar.ts, apps/desktop/src/i18n/de.ts, apps/desktop/src/i18n/en.ts, apps/desktop/src/i18n/es.ts, apps/desktop/src/i18n/fr.ts, apps/desktop/src/i18n/ja.ts, apps/desktop/src/i18n/ru.ts, apps/desktop/src/i18n/types.ts, apps/desktop/src/i18n/zh-hant.ts (+6 more)

4 PRs closed without merging

From the close comments: superseded by another PR 2 · duplicate 1 · other 1

  • #109967 fix(shared): validate contrast ladder step · other → #109955, #109975
  • #109972 fix(shared): normalize invalid ensureContrast rung sizes so the ladder terminates · duplicate → #109967
  • #109975 fix(shared): normalize invalid ensureContrast step values before the ladder loop · superseded by another PR → #122076
  • #110800 fix(shared): ensureContrast terminates for non-advancing step values (#109955) · superseded by another PR → #109975
Closed issues · 1
  • Closed#109955[Bug]: shared ensureContrast fails to terminate or meet contrast for invalid step values
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.33: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#122076
Closed issues
1
Attempts
4 PRs closed without merging
Fix link checked
27 Sep 2026

For your agent

The same facts, typed.

cluster/109955.json
cluster/109955.md