Classic-CLI approval prompts missing observer hook calls
Cluster 131876. Data as of
Nothing open on GitHub. Fix merged in #133162 on 5 Oct 2026. Check it covers your case.
The short answer
- Known?
- Yes. 3 related items grouped here, 1 issue already closed.
- Fix event
- A fix was merged to main in PR #133162. Check it covers your case. No release data is tracked.
- Tracker
- The maintainers' tracker marks this
resolved, deciding PR #133162. That is separate from the fix event. - Still open
- Nothing open on GitHub.
These items address two classic-CLI approval prompts that do not fire the expected pre_approval_request and post_approval_response observer hooks. The work involves identifying the gap and applying a fix so those hooks are triggered consistently.
Open issues0
Open PRs0
Fixes on record
-
#133162 Classic-CLI protected-write and MCP/vault consent prompts fire approval hooks (#131876, salvage #131928)
files:
hermes_cli/plugins.py,tests/tools/test_approval_plugin_hooks.py,tools/approval_prompt.py,tools/file_tools_write_guards.py,website/docs/user-guide/features/hooks.md
1 PR closed without merging
From the close comments: merged via another change 1
-
#131928 fix(approval): fire observer hooks for the two hookless classic-CLI prompts · merged via another change →
#133162
Closed issues · 1
- Closed#131876Two classic-CLI approval prompts fire no `pre_approval_request` / `post_approval_response` hooks
How this cluster was grouped
-
Link evidence (
structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference. -
Pairwise link density
0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36.1.00means every pair is linked.
Pick up a Lab task
Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.
Open the LabAt a glance
- Merged PRs
- #133162
- Closed issues
- 1
- Attempts
- 1 PR closed without merging
- Fix link checked
- 5 Oct 2026