Cairn

Fix visited-set sharing in resolve_toolset deduplication

NousResearch/hermes-agent · cluster 2134 · agent

Data as of

Nothing open on GitHub. Fix merged in #2311. Check it covers your case.

The short answer

0open issues
0open PRs
5items grouped
Known?
Yes. 5 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #2311. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #2311. That is separate from the fix event.
Still open
Nothing open on GitHub.

These issues and PRs address a bug in resolve_toolset() where the visited set is copied rather than shared across branches, causing diamond dependency patterns to be processed multiple times. The proposed fix passes the visited set by reference so sibling and cross-branch includes are properly deduplicated.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #2311 fix(toolsets): pass visited set by reference to prevent diamond dependency duplication

    merged to main

    files: toolsets.py

3 PRs closed without merging

From the close comments: done elsewhere 1 · merged via another change 1 · other 1

  • #2135 fix(toolsets): share visited set across sibling includes in resolve_toolset() · done elsewhere
  • #2252 fix(toolsets): share visited set across branches in resolve_toolset() · other
  • #2292 fix(toolsets): pass visited set by reference to prevent diamond dependency duplication · merged via another change → #2311
Closed issues · 1
  • Closed#2134fix(toolsets): resolve_toolset() uses visited.copy() preventing cross-branch deduplication
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.40: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem
agent
Merged PRs
#2311
Closed issues
1
Attempts
3 PRs closed without merging
Fix link checked
21 Mar 2026. This confirmation is old and may be out of date (a revert or reopen would not have invalidated it here); re-verify.

For your agent

The same facts, typed.

cluster/2134.json
cluster/2134.md