Cairn
NousResearch/hermes-agent

PTY session disposal on desktop quit/restart

Cluster 48335. Data as of

Nothing open on GitHub. Fix merged in #48421 on 18 Jun 2026. Check it covers your case.

The short answer

0open issues
0open PRs
3items grouped
Known?
Yes. 3 related items grouped here, 1 issue already closed.
Fix event
A fix was merged to main in PR #48421. Check it covers your case. No release data is tracked.
Tracker
The maintainers' tracker marks this resolved, deciding PR #48421. That is separate from the fix event.
Still open
Nothing open on GitHub.

These items concern a crash or race condition during application quit or update-restart caused by open PTY sessions not being disposed in the before-quit handler. Two are fixes and one is a bug report describing the underlying issue.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

  • #48421 fix(desktop): dispose open PTY sessions in before-quit handler

    merged to main

    files: apps/desktop/electron/main.cjs, scripts/release.py

    Show the diff
    • apps/desktop/electron/main.cjs
      @@ -6551,6 +6551,12 @@ app.on('before-quit', () => {
   flushDesktopLogBufferSync()
   closePreviewWatchers()
 
+  // Kill open PTYs before environment teardown to avoid the node-pty#904
+  // ThreadSafeFunction SIGABRT race.
+  for (const id of [...terminalSessions.keys()]) {
+    disposeTerminalSession(id)
+  }
+
   if (hermesProcess && !hermesProcess.killed) {
     hermesProcess.kill('SIGTERM')
   }
    • scripts/release.py
      @@ -45,6 +45,7 @@
 
 # Auto-extracted from noreply emails + manual overrides
 AUTHOR_MAP = {
+    "[email protected]": "srojk34",
     "[email protected]": "sitkarev",
     "[redacted:email]": "omegazheng",
     "[email protected]": "james47kjv",

1 PR closed without merging

From the close comments: merged via another change 1

  • #48393 fix(desktop): dispose open PTY sessions in before-quit handler · merged via another change → #48421, #904, #48335
Closed issues · 1
  • Closed#48335Desktop: SIGABRT crash on quit/update-restart — node-pty ThreadSafeFunction teardown race (ptys not disposed in before-quit)
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.67: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs
#48421
Closed issues
1
Attempts
1 PR closed without merging
Fix link checked
18 Jun 2026

For your agent

The same facts, typed.

cluster/48335.json
cluster/48335.md