NousResearch/hermes-agent

API key redaction gaps for dotted and Zhipu keys

Cluster 113901. Data as of 2026-10-24 13:18 UTC

Nothing open on GitHub. Fix merged in #114839 on 18 Sep 2026. Check it covers your case.

open issues

open PRs

items grouped

Known?: Yes. 4 related items grouped here, 1 issue already closed.
Fix event: A fix was merged to main in PR #114839. Check it covers your case. No release data is tracked.
Tracker: The maintainers' tracker marks this resolved, deciding PR #114839. That is separate from the fix event.
Still open: Nothing open on GitHub.

Next step: read #114839, then check it covers your case.

Read #114839 Pick up a Lab task

These issues and pull requests address secret redaction logic failing to mask API keys that contain dots after 'sk-' or use a prefix-less format, as seen with Zhipu API keys. The work focuses on expanding redaction patterns to cover these previously missed key shapes.

Open issues0

No open issues.

Open PRs0

No open pull requests.

Fixes on record

Merged to main. A stamp counts the issues a fix is linked to.

#114839 fix(redact): dotted sk- keys and prefix-less Zhipu keys are fully masked in tool output (#113901, #78128, #106508, salvage #113908)

merged to main

files: agent/redact.py, tests/agent/test_redact.py, tests/tools/test_mcp_tool.py, tools/mcp_tool_common.py

2 PRs closed without merging

From the close comments: merged via another change 1 · superseded by another PR 1

#113908 fix(agent): redact dotted and Zhipu API keys · merged via another change → dd07510, #114839, #113901, #78128, #106508, #113908
#113916 fix(redact): mask dotted sk- keys fully and Zhipu's prefix-less key shape · superseded by another PR → d41d8cd, #113908, #113901

Closed issues · 1

Closed#113901Secret redaction misses dot-containing and non-sk- prefixed API keys

How this cluster was grouped

Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
Pairwise link density 0.50: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Merged PRs: #114839
Closed issues: 1
Attempts: 2 PRs closed without merging
Fix link checked: 18 Sep 2026

For your agent

The same facts, typed.

cluster/113901.json
cluster/113901.md