Cairn
NousResearch/hermes-agent

Fix modal terminal tests to use assertions not returns

Cluster 13286 · environments. Data as of

2 open items. Fix attempted, not merged.

The short answer

1open issue
1open PR
4items grouped
Known?
Yes. 4 related items grouped here, 0 issues already closed.
Fix event
No fix has been merged to main. 2 PRs closed without merging; see the attempts below.
Tracker
The maintainers' tracker marks this unresolved. That is separate from the fix event.
Still open
1 issue and 1 PR.

These issues and PRs address a bug where integration tests in test_modal_terminal.py returned boolean values instead of using assert statements, causing test failures to silently pass under pytest.

Open issues1

  • Issue#13286Bug: tests/integration/test_modal_terminal.py returns booleans so logical failures still pass under pytest

Open PRs1

  • PR#13325fix(tests): assert modal terminal integration failures

2 PRs closed without merging

From the close comments: duplicate 1 · superseded by another PR 1

  • #13318 fix(tests): make test_modal_terminal actually assert, not return booleans · duplicate → #13325, #13286
  • #16088 test(modal): convert test_* return values to assert/skip · superseded by another PR → #13318
How this cluster was grouped
  • Link evidence (structural links throughout): every member is connected by structural evidence: shared changed files, or a closing/superseded reference.
  • Pairwise link density 0.50: the share of item pairs that carry a link, counting a structural link in full and a relevance-only link at 0.36. 1.00 means every pair is linked.

Pick up a Lab task

Check whether a fix covers the open issues here, with your own agent. Bring back evidence for maintainers.

Open the Lab

At a glance

Subsystem
environments
Closed issues
0
Attempts
2 PRs closed without merging

For your agent

The same facts, typed.

cluster/13286.json
cluster/13286.md